[PATCH] D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:1951
+  DefaultAttrsIntrinsic<[llvm_i32_ty],
+            [llvm_anyint_ty, llvm_i64_ty, llvm_i64_ty],
+            [IntrNoMem, IntrNoSync, IntrWillReturn]>;
----------------
Any reason for the arguments to be i64 instead of i32?

Are they always constants?


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp:1389
+    Constant *WidthArg = State.Builder.getInt64(*State.ElementWidth);
+    Constant *RWFactorArg = State.Builder.getInt64(*State.RegWidthFactor);
+
----------------
What is RegWidthFactor supposed to represent?

Can we make this the VF instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99750/new/

https://reviews.llvm.org/D99750