[PATCH] D149610: [llvm-objdump][COFF] Skip empty entries when dumping the export table

[Alvin Wong via Phabricator via llvm-commits]

alvinhochun added a comment.

I don't think we should skip empty exports, especially not by checking only the RVA, because it looks like it is theoretically possible to have RVA = 0 but a non-empty name for an export. Even entries with null RVA and null name seems worth keeping as they do take up space in the export table.

I don't think we need to follow exactly the behaviour of dumpbin. Can you check what Binutils objdump does just for comparison?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149610/new/

https://reviews.llvm.org/D149610