[PATCH] D149610: [llvm-objdump][COFF] Skip empty entries when dumping the export table

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 02:07:27 PDT 2023


mstorsjo added a comment.

In D149610#4311751 <https://reviews.llvm.org/D149610#4311751>, @hans wrote:

> Can you share what future change this will simplify? The current output seems natural in a way.

I think it might be D149611 <https://reviews.llvm.org/D149611> - which is marked as a child revision, but doesn't seem to be made including the changes from this patch.

Currently, for these cases we do have empty stub entries in the export tables, but with D149611 <https://reviews.llvm.org/D149611> we'll also be creating export tables that start from a different ordinal. I think it might be good to visually see the difference between those two cases?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149610/new/

https://reviews.llvm.org/D149610



More information about the llvm-commits mailing list