[llvm] 73fbe9c - add_tablegen: Remove LLVM_ENABLE_OBJLIB

[NAKAMURA Takumi via llvm-commits]

Author: NAKAMURA Takumi
Date: 2023-05-02T14:04:41+09:00
New Revision: 73fbe9c9291a9bbbae3bf345d8cead160f190af7

URL: https://github.com/llvm/llvm-project/commit/73fbe9c9291a9bbbae3bf345d8cead160f190af7
DIFF: https://github.com/llvm/llvm-project/commit/73fbe9c9291a9bbbae3bf345d8cead160f190af7.diff

LOG: add_tablegen: Remove LLVM_ENABLE_OBJLIB

- It doesn't work if `ALL_FILES` has `$<TARGET_OBJECTS>` with Makefile generator.
- It was a micro-optimization in the ancient age. (introduced in rGe6bc093b42ff)

Added: 
    

Modified: 
    llvm/cmake/modules/TableGen.cmake

Removed: 
    


################################################################################
diff  --git a/llvm/cmake/modules/TableGen.cmake b/llvm/cmake/modules/TableGen.cmake
index 66303450b2979..be16127c724ea 100644
--- a/llvm/cmake/modules/TableGen.cmake
+++ b/llvm/cmake/modules/TableGen.cmake
@@ -143,12 +143,6 @@ macro(add_tablegen target project)
   set(${target}_OLD_LLVM_LINK_COMPONENTS ${LLVM_LINK_COMPONENTS})
   set(LLVM_LINK_COMPONENTS ${LLVM_LINK_COMPONENTS} TableGen)
 
-  # CMake doesn't let compilation units depend on their dependent libraries on some generators.
-  if(NOT CMAKE_GENERATOR MATCHES "Ninja" AND NOT XCODE)
-    # FIXME: It leaks to user, callee of add_tablegen.
-    set(LLVM_ENABLE_OBJLIB ON)
-  endif()
-
   add_llvm_executable(${target} DISABLE_LLVM_LINK_LLVM_DYLIB
     ${ADD_TABLEGEN_UNPARSED_ARGUMENTS})
   set(LLVM_LINK_COMPONENTS ${${target}_OLD_LLVM_LINK_COMPONENTS})