[PATCH] D149002: [compiler-rt][interception][asan][win] Improve error reporting

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_mac.cpp:47
 namespace __asan {
 
+void PlatformBeforeInitializeAsanInterceptors() {}
----------------
Can we instead move InitializePlatformInterceptors() in to the beginning of InitializeAsanInterceptors()?


================
Comment at: compiler-rt/lib/interception/interception_win.cpp:157-161
+#  define Report(...)                     \
+    do {                                  \
+      if (ErrorReportCallback)            \
+        ErrorReportCallback(__VA_ARGS__); \
+    } while (0)
----------------
Can we avoid a macro?
static inline should work?

Can you call it ReportError, to avoid confusion for Report in common


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149002/new/

https://reviews.llvm.org/D149002