[PATCH] D145884: test-release.sh: build projects and runtimes lists with semicolons

Sat Apr 29 12:36:46 PDT 2023

mstorsjo added a comment.

In D145884#4305349 <https://reviews.llvm.org/D145884#4305349>, @dim wrote:

> In D145884#4304136 <https://reviews.llvm.org/D145884#4304136>, @mstorsjo wrote:
>
>> Right, but the build that uses `CMAKE_TRY_COMPILE_TARGET_TYPE=STATIC_LIBRARY` is for `compiler-rt/lib/builtins` only - that won't be set for a build that targets all of compiler-rt, so the fuzzer parts should't be affected, I think?
>
> Indeed, it looks like the error won't matter for either the builtins or the runtimes.

Ok, great, then we're on the same page - thanks for taking the time to wade through the reasoning!

> So it is probably not necessary to revert rG8368e4d54c459fe173d76277f17c632478e91add <https://reviews.llvm.org/rG8368e4d54c459fe173d76277f17c632478e91add>, as I assume that would cause other trouble.

Maybe; the main trouble would be that I would need to reintroduce `-DCMAKE_C_COMPILER_WORKS=TRUE -DCMAKE_CXX_COMPILER_WORKS=TRUE` in my setup where I build compiler-rt builtins, but I think that's fine.

For context: I started out wanting to clean this up so that people setting up a toolchain from scratch wouldn't need to set those flags. This worked for compiler-rt/lib/builtins (but with some warts as you've noticed), but turned out to not work for libunwind/libcxxabi/libcxx (which need to do a bit of link testing, while setting `CMAKE_TRY_COMPILE_TARGET_TYPE=STATIC_LIBRARY` makes all link testing no-ops). So when we're not progressing towards the goal of not needing the `*_COMPILER_WORKS` flags anyway, it might be good to get rid of this inconsistency in compiler-rt/lib/builtins too.

I'll see if I send patch for that later.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145884/new/

https://reviews.llvm.org/D145884