[PATCH] D149002: [compiler-rt][interception][win] Improve error reporting

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 14:27:51 PDT 2023


vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/interception/interception_win.cpp:130
 #if SANITIZER_WINDOWS
+#include "sanitizer_common/sanitizer_common.h"
+#include "sanitizer_common/sanitizer_libc.h"
----------------
We want to avoid dependency of interceptors on most of sanitizer_common
For most users these messages is just a spam, they unlikely will rebuild and fix sanitizers.
So it's rather helpful but unnecessary debug leftovers for folks like us.

I prefer we don't land this one and dependent patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149002/new/

https://reviews.llvm.org/D149002



More information about the llvm-commits mailing list