[PATCH] D145884: test-release.sh: build projects and runtimes lists with semicolons

Thu Apr 27 22:57:14 PDT 2023

mstorsjo added a comment.

In D145884#4303549 <https://reviews.llvm.org/D145884#4303549>, @dim wrote:

> In D145884#4303276 <https://reviews.llvm.org/D145884#4303276>, @mstorsjo wrote:
>
>> In D145884#4283446 <https://reviews.llvm.org/D145884#4283446>, @dim wrote:
>>
>>> Well, the builtins and runtimes CMake stuff is run as a separate step from the 'main' build, so I assume the detection results end up in separate CMakeCache files. That said, I am unsure whether any of the builtins or runtimes even care about, or use zlib. In case they do, detecting it properly is important, otherwise the "could not find" message should either be silenced or avoided.
>>
>> Oh, ok, so the issue is only on the level of printing a surprising failed detection, but no actual noted missing/differing behaviour?
>
> Some cursory searching in compiler-rt finds that at least `compiler-rt/test/fuzzer/CompressedTest.cpp` tries to use zlib, to "consume a Zlib-compressed input". I guess that one test wouldn't work then.

Right, but the build that uses `CMAKE_TRY_COMPILE_TARGET_TYPE=STATIC_LIBRARY` is for `compiler-rt/lib/builtins` only - that won't be set for a build that targets all of compiler-rt, so the fuzzer parts should't be affected, I think?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145884/new/

https://reviews.llvm.org/D145884