[PATCH] D145884: test-release.sh: build projects and runtimes lists with semicolons

[Dimitry Andric via Phabricator via llvm-commits]

dim added a comment.

In D145884#4303276 <https://reviews.llvm.org/D145884#4303276>, @mstorsjo wrote:

> In D145884#4283446 <https://reviews.llvm.org/D145884#4283446>, @dim wrote:
>
>> In D145884#4269404 <https://reviews.llvm.org/D145884#4269404>, @mstorsjo wrote:
>>
>>> In D145884#4269286 <https://reviews.llvm.org/D145884#4269286>, @dim wrote:
>>>
>>>> `compiler-rt/lib/builtins/CMakeLists.txt` includes `compiler-rt/cmake/Modules/CompilerRTUtils.cmake`, then it calls `load_llvm_config()` (a helper function from `CompilertRTUtils`). `load_llvm_config()` figures out the path to `llvm/cmake`, and as far I understand, loads all kinds of settings from there, including paths to llvm headers, libraries, etc. As part of this, it clearly also descends into the "finding required libraries" parts, as it searches for terminfo, zlib, libxml2, etc.
>>>>
>>>> However, when building the runtimes, it starts from the top-level `runtimes/CMakeLists.txt`, so it doesn't seem to follow this logic.
>>>
>>> Right, but when the build of `compiler-rt/lib/builtins` failed to detect zlib, where does that detection result end up used? I presume that the result of that detection ends up in a cmake cache, but I would presume that that cmake cache is specific for the builtins cmake invocation, not influencing other steps (where `CMAKE_TRY_COMPILE_TARGET_TYPE=STATIC_LIBRARY` shouldn't have any effect).
>>
>> Well, the builtins and runtimes CMake stuff is run as a separate step from the 'main' build, so I assume the detection results end up in separate CMakeCache files. That said, I am unsure whether any of the builtins or runtimes even care about, or use zlib. In case they do, detecting it properly is important, otherwise the "could not find" message should either be silenced or avoided.
>
> Oh, ok, so the issue is only on the level of printing a surprising failed detection, but no actual noted missing/differing behaviour?

Some cursory searching in compiler-rt finds that at least `compiler-rt/test/fuzzer/CompressedTest.cpp` tries to use zlib, to "consume a Zlib-compressed input". I guess that one test wouldn't work then.

I couldn't find any mention of zlib in the other runtimes, e.g. libcxx, libcxxabi and libunwind.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145884/new/

https://reviews.llvm.org/D145884