[PATCH] D149347: [LLD][ELF] Fix --check-dynamic-relocations for 32-bit targets

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/SyntheticSections.cpp:1568
+  case AgainstSymbolWithTargetVA: {
+    int64_t ca = InputSection::getRelocTargetVA(inputSec->file, type, addend,
+                                                getOffset(), *sym, expr);
----------------



================
Comment at: lld/test/ELF/arm-pie-relative.s:6
 // RUN: llvm-readelf -x .got %t | FileCheck %s --check-prefix=GOT
+// RUN: ld.lld %t.o --pie --image-base=0x80000000 --check-dynamic-relocations -o /dev/null
 
----------------
arichardson wrote:
> This test could do with a comment or some check lines?
Adding a `llvm-readelf -x .got` will make it more useful.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149347/new/

https://reviews.llvm.org/D149347