[PATCH] D149347: [LLD][ELF] Fix --check-dynamic-relocations for 32-bit targets

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 08:10:25 PDT 2023


arichardson added a comment.

Change looks sensible to me but the test could do with some kind of explanation of what it's doing.



================
Comment at: lld/test/ELF/arm-pie-relative.s:6
 // RUN: llvm-readelf -x .got %t | FileCheck %s --check-prefix=GOT
+// RUN: ld.lld %t.o --pie --image-base=0x80000000 --check-dynamic-relocations -o /dev/null
 
----------------
This test could do with a comment or some check lines?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149347/new/

https://reviews.llvm.org/D149347



More information about the llvm-commits mailing list