[PATCH] D149361: [profiling] Improve error message for raw profile header mismatches

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 14:47:57 PDT 2023


paquette added inline comments.


================
Comment at: llvm/lib/ProfileData/InstrProfReader.cpp:540
+                  "\nPLEASE update this tool to version in the raw profile, or "
+                  "regenerate raw profile with expected version.")
+                     .str());
----------------
jroelofs wrote:
> Given how pervasive the problem is, maybe the error message should also link to the docs explaining what the compatibility guarantees are/are-not.
That's a good idea, but the docs are in Clang right now. I'll see if I can move them to LLVM or duplicate them there so that other compiler frontend users aren't confused.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149361/new/

https://reviews.llvm.org/D149361



More information about the llvm-commits mailing list