[PATCH] D149361: [profiling] Improve error message for raw profile header mismatches

Jon Roelofs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 11:09:28 PDT 2023


jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/ProfileData/InstrProfReader.cpp:540
+                  "\nPLEASE update this tool to version in the raw profile, or "
+                  "regenerate raw profile with expected version.")
+                     .str());
----------------
Given how pervasive the problem is, maybe the error message should also link to the docs explaining what the compatibility guarantees are/are-not.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149361/new/

https://reviews.llvm.org/D149361



More information about the llvm-commits mailing list