[PATCH] D149358: [AMDGPU] Track liveins for max-ilp-sched-strategy

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 11:17:23 PDT 2023


rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.

LGTM with couple nits.



================
Comment at: llvm/test/CodeGen/AMDGPU/schedule-ilp-liveness-tracking.mir:2
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py UTC_ARGS: --version 2
+# RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx90a -amdgpu-enable-max-ilp-scheduling-strategy -verify-machineinstrs  -run-pass=machine-scheduler -verify-misched -o - %s | FileCheck %s
+
----------------
Please remove double whitespace before -run-pass.


================
Comment at: llvm/test/CodeGen/AMDGPU/schedule-ilp-liveness-tracking.mir:34
+...
+
----------------
Please remove blank line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149358/new/

https://reviews.llvm.org/D149358



More information about the llvm-commits mailing list