[PATCH] D149254: [AMDGPU][MC] Clean up DPP bound_crtl handling

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 03:48:10 PDT 2023


rovka updated this revision to Diff 517508.
rovka added a comment.

- Updated the docs
- Switched to GFX11+
- Refactored the code a bit: made convertDppBoundCtrl a member function and

updated parseIntWithPrefix to take a `std::function` so we can pass a lambda
binding `this` into it. This isn't exactly what Ivan suggested but it's in the
same spirit and allows us to keep the same interface for the callback (and use
the existing standalone functions where we don't need the AMDGPUAsmParser object)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149254/new/

https://reviews.llvm.org/D149254

Files:
  llvm/docs/AMDGPUModifierSyntax.rst
  llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  llvm/lib/Target/AMDGPU/SIInstrInfo.td
  llvm/test/MC/AMDGPU/gfx11_asm_vop1_dpp16.s
  llvm/test/MC/AMDGPU/gfx11_asm_vop2_dpp16.s
  llvm/test/MC/AMDGPU/gfx11_asm_vop3_dpp16.s
  llvm/test/MC/AMDGPU/gfx11_asm_vop3_dpp16_from_vop1.s
  llvm/test/MC/AMDGPU/gfx11_asm_vop3_dpp16_from_vop2.s
  llvm/test/MC/AMDGPU/gfx11_asm_vop3_dpp16_from_vopc.s
  llvm/test/MC/AMDGPU/gfx11_asm_vop3_dpp16_from_vopcx.s
  llvm/test/MC/AMDGPU/gfx11_asm_vop3p_dpp16.s
  llvm/test/MC/AMDGPU/gfx11_asm_vopc_dpp16.s
  llvm/test/MC/AMDGPU/gfx11_asm_vopcx_dpp16.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149254.517508.patch
Type: text/x-patch
Size: 300232 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230427/36cbf54b/attachment-0001.bin>


More information about the llvm-commits mailing list