[PATCH] D149254: [AMDGPU][MC] Clean up DPP bound_crtl handling

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp added a comment.

In D149254#4298967 <https://reviews.llvm.org/D149254#4298967>, @foad wrote:

> In D149254#4298864 <https://reviews.llvm.org/D149254#4298864>, @dp wrote:
>
>> IMO this change should be limited to GFX11 to preserve compatibility with existing assembly code.
>
> Why GFX11? Do you mean because it was the first architecture introduced *after* you fixed the disassembler to output bound_ctrl:1 instead of bound_ctrl:0 in D97048 <https://reviews.llvm.org/D97048>?

This patch only affects assembler and the changes break compatibility with existing code. 
I think there is a lot of asm code written for GFX9 and GFX10 and the code may theoretically use bound_ctrl:0 assuming the same behavior as bound_ctrl:1. This is less an issue with GFX11.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149254/new/

https://reviews.llvm.org/D149254