[PATCH] D148096: [AMDGPU][GlobalISel] Widen the vector operand in G_BUILD/INSERT/EXTRACT_VECTOR

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 09:44:43 PDT 2023


arsenm added a comment.

Needs new tests that now legalize? The test updates only show regressions?



================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/extractelement.ll:3619
 ; GCN-NEXT:    v_cmp_eq_u32_e32 vcc, 14, v0
-; GCN-NEXT:    v_cndmask_b32_e32 v0, v1, v15, vcc
+; GCN-NEXT:    v_cndmask_b32_e32 v1, v1, v15, vcc
+; GCN-NEXT:    v_cmp_eq_u32_e32 vcc, 15, v0
----------------
I'm surprised there are so many test changes / regressions 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148096/new/

https://reviews.llvm.org/D148096



More information about the llvm-commits mailing list