[PATCH] D149072: [CMake] Serialize `build_native_tool`

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D149072#4299252 <https://reviews.llvm.org/D149072#4299252>, @chapuni wrote:

>> This code works best if the tablegens are processed in a roughly topological order, e.g. in a build with clang and lldb, I guess it's better if clang is listed before lldb in `LLVM_ENABLE_PROJECTS`, because otherwise `clang-tablegen-host` would build `lldb-tablegen-host` before?
>
> I think such optimization would not gain the big win.

I can try to check if this happens or not.

> Nested CMake invocation would be evil and far from optimal I suppose.

I don't quite understand what you refer to here?

> I just wanted to introduce consistency.
>
> That said, I will not stop someone's proposing better scheduling.

I don't think it's necessarily worth spending effort on at this point, I just wanted to note the pros and cons. Doing things suboptimally (in a case where it's trivial for the user to fix it) is totally fine, compared to doing things in an unspecified possibly broken way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149072/new/

https://reviews.llvm.org/D149072