[PATCH] D149072: [CMake] Serialize `build_native_tool`

NAKAMURA Takumi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 09:26:02 PDT 2023


chapuni added a comment.

In D149072#4296385 <https://reviews.llvm.org/D149072#4296385>, @mstorsjo wrote:

> I think this looks reasonable, and the logic seems mostly better than the one before. As far as I can see with the current code in git, there's nothing stopping from building e.g. `lldb-tablegen-host` and `clang-tablegen-host` at the same time, is that right?

I haven't experienced lldb, though, I guess `lldb-tablegen-host` and `clang-tablegen-host` would be scheduled in parallel.

> This code works best if the tablegens are processed in a roughly topological order, e.g. in a build with clang and lldb, I guess it's better if clang is listed before lldb in `LLVM_ENABLE_PROJECTS`, because otherwise `clang-tablegen-host` would build `lldb-tablegen-host` before?

I think such optimization would not gain the big win. Nested CMake invocation would be evil and far from optimal I suppose.
I just wanted to introduce consistency.

That said, I will not stop someone's proposing better scheduling.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149072/new/

https://reviews.llvm.org/D149072



More information about the llvm-commits mailing list