[PATCH] D149254: [AMDGPU][MC] Clean up DPP bound_crtl handling

Ivan Kosarev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 06:36:10 PDT 2023


kosarev added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.td:1276
 def bank_mask : NamedOperandU32<"BankMask", NamedMatchClass<"BankMask">>;
-def bound_ctrl : NamedIntOperand<i1, "bound_ctrl", "DppBoundCtrl", "ConvertDppBoundCtrl">;
+def bound_ctrl : CustomOperand<i1, 1, "DppBoundCtrl">;
 def FI : NamedOperandU32<"FI", NamedMatchClass<"FI">>;
----------------
What if instead pass the AMDGPUAsmParser object to the conversion handler so ConvertDppBoundCtrl() could call isGFX9Plus() itself?

```
  OperandMatchResultTy
  parseIntWithPrefix(const char *Prefix, OperandVector &Operands,
                     AMDGPUOperand::ImmTy ImmTy = AMDGPUOperand::ImmTyNone,
                     bool (*ConvertResult)(int64_t &, const AMDGPUAsmParser &) = nullptr);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149254/new/

https://reviews.llvm.org/D149254



More information about the llvm-commits mailing list