[PATCH] D149254: [AMDGPU][MC] Clean up DPP bound_crtl handling

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 06:12:12 PDT 2023


rovka created this revision.
Herald added subscribers: kosarev, foad, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl, arsenm.
Herald added a project: All.
rovka requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

At the moment, we set the BC bit in DPP for both bound_ctrl:0 and
bound_ctrl:1, for compatibility with sp3 (see PR35397). However, this
hack is only needed for GFX8. For newer GFXs, sp3 behaves as expected,
i.e. it sets the bit when bound_ctrl:1 and clears it when bound_ctrl:0.
This patch updates LLVM to do the same.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149254

Files:
  llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  llvm/lib/Target/AMDGPU/SIInstrInfo.td
  llvm/test/MC/AMDGPU/dl-insts.s
  llvm/test/MC/AMDGPU/gfx10_asm_dpp16.s
  llvm/test/MC/AMDGPU/gfx10_asm_vop1.s
  llvm/test/MC/AMDGPU/gfx10_asm_vop2.s
  llvm/test/MC/AMDGPU/gfx11_asm_vop1_dpp16.s
  llvm/test/MC/AMDGPU/gfx11_asm_vop2_dpp16.s
  llvm/test/MC/AMDGPU/gfx11_asm_vop3_dpp16.s
  llvm/test/MC/AMDGPU/gfx11_asm_vop3_dpp16_from_vop1.s
  llvm/test/MC/AMDGPU/gfx11_asm_vop3_dpp16_from_vop2.s
  llvm/test/MC/AMDGPU/gfx11_asm_vop3_dpp16_from_vopc.s
  llvm/test/MC/AMDGPU/gfx11_asm_vop3_dpp16_from_vopcx.s
  llvm/test/MC/AMDGPU/gfx11_asm_vop3p_dpp16.s
  llvm/test/MC/AMDGPU/gfx11_asm_vopc_dpp16.s
  llvm/test/MC/AMDGPU/gfx11_asm_vopcx_dpp16.s
  llvm/test/MC/AMDGPU/gfx9_asm_vop1.s
  llvm/test/MC/AMDGPU/gfx9_asm_vop2.s
  llvm/test/MC/AMDGPU/vop_dpp.s
  llvm/test/MC/AMDGPU/vop_dpp_expr.s
  llvm/test/MC/AMDGPU/xdl-insts-gfx1011-gfx1012.s
  llvm/test/MC/AMDGPU/xdl-insts-gfx908.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149254.517142.patch
Type: text/x-patch
Size: 461376 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230426/ecfc1f78/attachment-0001.bin>


More information about the llvm-commits mailing list