[PATCH] D148316: [AArch64] Add support for efficient bitcast in vector truncate store.

Lawrence Benson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 02:41:26 PDT 2023


lawben updated this revision to Diff 517109.
lawben added a comment.

Added check for illegal types. I could not get this check to actually fire. The type is legalized before the bitcast in the bitcast lowering case, and it is legalized before the 
store becomes a truncating store. So in both cases other checks prevent bad things from happening. But it is probably still fine to keep it as a defensive check in case things 
change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148316/new/

https://reviews.llvm.org/D148316

Files:
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/test/CodeGen/AArch64/setcc-type-mismatch.ll
  llvm/test/CodeGen/AArch64/vec-combine-compare-to-bitmask.ll
  llvm/test/CodeGen/AArch64/vec-combine-compare-truncate-store.ll
  llvm/test/CodeGen/AArch64/vec_uaddo.ll
  llvm/test/CodeGen/AArch64/vec_umulo.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148316.517109.patch
Type: text/x-patch
Size: 18132 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230426/0bc1cc13/attachment.bin>


More information about the llvm-commits mailing list