[PATCH] D149161: AMDGPU: Fix an assertion in SIOptimizeVGPRLiveRange

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Could really use a mir test for these sorts of issues



================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp:535
       continue;
     }
 
----------------
Could this see an undef subregister def? Should probably be assert !O.readsReg() (or maybe the loop is buggy to begin with by using use_operands?)


================
Comment at: llvm/test/CodeGen/AMDGPU/bug-deadlanes.ll:9-11
+source_filename = "lgcPipeline"
+target datalayout = "e-p:64:64-p1:64:64-p2:32:32-p3:32:32-p4:64:64-p5:32:32-p6:32:32-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-v2048:2048-n32:64-S32-A5-G1-ni:7"
+target triple = "amdgcn--amdpal"
----------------
Can drop this 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149161/new/

https://reviews.llvm.org/D149161