[PATCH] D149199: [SelectionDAG] Fill in some more cases in `isKnownNeverZero`

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5031
     break;
+    return isKnownNeverZero(Op.getOperand(0), Depth);
+
----------------
return after break?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5066
+      return isKnownNeverZero(Op.getOperand(0), Depth);
+
+
----------------
too many blank lines


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5069
+    break;
+  case ISD::ADD: {
+    if (Op->getFlags().hasNoUnsignedWrap())
----------------
I don't think curly braces are needed here


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5086
+  }
+  case ISD::MUL: {
+    if (Op->getFlags().hasNoSignedWrap() || Op->getFlags().hasNoUnsignedWrap())
----------------
Or here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149199/new/

https://reviews.llvm.org/D149199