[PATCH] D149199: [SelectionDAG] Fill in some more cases in `isKnownNeverZero`
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 25 14:37:18 PDT 2023
craig.topper added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5016
case ISD::OR:
- if (isKnownNeverZero(Op.getOperand(1)) ||
- isKnownNeverZero(Op.getOperand(0)))
+ return isKnownNeverZero(Op.getOperand(0), Depth) ||
+ isKnownNeverZero(Op.getOperand(1), Depth);
----------------
I assume we checked operand 1 first to favor the cheap case of a non-zero constant right hand side.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149199/new/
https://reviews.llvm.org/D149199
More information about the llvm-commits
mailing list