[PATCH] D149068: [llvm-mca][RISCV] Fix checking if data valid in createInstrument

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 24 09:04:17 PDT 2023


myhsu accepted this revision.
myhsu added a comment.
This revision is now accepted and ready to land.

LGTM
Though I'm a little surprised it doesn't print a warning or even error for invalid instruments. Is there any reason behind this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149068/new/

https://reviews.llvm.org/D149068



More information about the llvm-commits mailing list