[PATCH] D149068: [llvm-mca][RISCV] Fix checking if data valid in createInstrument

Michael Maitland via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 24 07:57:28 PDT 2023


michaelmaitland created this revision.
Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, hiraditya, arichardson.
Herald added a project: All.
michaelmaitland requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead, eopXD, MaskRay.
Herald added a project: LLVM.

Fixes createInstrument to return instrument when LMUL data is valid, and 
return nullptr when LMUL data is not valid for RISCV target.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149068

Files:
  llvm/lib/Target/RISCV/MCA/RISCVCustomBehaviour.cpp


Index: llvm/lib/Target/RISCV/MCA/RISCVCustomBehaviour.cpp
===================================================================
--- llvm/lib/Target/RISCV/MCA/RISCVCustomBehaviour.cpp
+++ llvm/lib/Target/RISCV/MCA/RISCVCustomBehaviour.cpp
@@ -81,7 +81,7 @@
                       << '\n');
     return nullptr;
   }
-  if (RISCVLMULInstrument::isDataValid(Data)) {
+  if (!RISCVLMULInstrument::isDataValid(Data)) {
     LLVM_DEBUG(dbgs() << "RVCB: Bad data for instrument kind " << Desc << ": "
                       << Data << '\n');
     return nullptr;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149068.516413.patch
Type: text/x-patch
Size: 554 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230424/6ade1d6d/attachment-0001.bin>


More information about the llvm-commits mailing list