[PATCH] D149063: [RISCV] Custom lowering of llvm.is.fpclass

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4176-4195
+    if (Check & fcSNan)
+      TDCMask |= RISCV::FPMASK_Signaling_NaN;
+    if (Check & fcQNan)
+      TDCMask |= RISCV::FPMASK_Quiet_NaN;
+    if (Check & fcPosInf)
+      TDCMask |= RISCV::FPMASK_Positive_Infinity;
+    if (Check & fcNegInf)
----------------
Converting the mask values should probably be a separate utility function 


================
Comment at: llvm/test/CodeGen/RISCV/float-intrinsics.ll:1229
+; RV64I-NEXT:    ret
+  %cmp = call i1 @llvm.is.fpclass.f32(float %x, i32 639)
+  ret i1 %cmp
----------------
Needs much more expensive test coverage. Can just copy another target's maybe 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149063/new/

https://reviews.llvm.org/D149063