[PATCH] D149049: [AMDGPU][Disassembler] Fix a spurious error message in an instruction comment.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 24 03:19:40 PDT 2023


foad added a comment.

Do we have any tests that errors like "Error: cannot read literal..." are still emitted when they actually cause the disassembly to fail?



================
Comment at: llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp:416
                                                 raw_ostream &CS) const {
   CommentStream = &CS;
   bool IsSDWA = false;
----------------
Is this still required?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149049/new/

https://reviews.llvm.org/D149049



More information about the llvm-commits mailing list