[PATCH] D149049: [AMDGPU][Disassembler] Fix a spurious error message in an instruction comment.
Ivan Kosarev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 24 03:15:08 PDT 2023
kosarev added a comment.
Note that with the change in place no comments passed to `AMDGPUDisassembler::errOperand()` may ever be visible to the user, because that function returns a default-constructed `MCOperand`, which is considered invalid by `addOperand()` defined in `AMDGPUDisassembler.cpp` and so instructions having such operands will always be seen as failed decoding attempts. To expose the error messages we would need to support erroneous operands as the comment in `AMDGPUDisassembler::errOperand()` proposes or find another way.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149049/new/
https://reviews.llvm.org/D149049
More information about the llvm-commits
mailing list