[PATCH] D134600: [RISCV][LLD] Add RISCV zcmt optimise in linker relaxation

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: lld/ELF/Arch/RISCV.cpp:337
   case R_RISCV_32:
+    if (config->riscvTbljal && (read16le(loc) & 0xfc03) == 0xa002)
+      return;
----------------
These are extremely dodgy


================
Comment at: lld/ELF/Arch/RISCV.cpp:765
         relaxHi20Lo12(sec, i, loc, r, remove);
+
+    case R_RISCV_JAL:
----------------
Blank line doesn't match style


================
Comment at: lld/ELF/Arch/RISCV.cpp:769
+          sec.relocations[i + 1].type == R_RISCV_RELAX)
+        relaxZcmt(sec, i, loc, r, remove);
       break;
----------------
This naming doesn't fit


================
Comment at: lld/ELF/Arch/RISCV.cpp:1193
+
+void TableJumpSection::scanTableJumpEntrys(const InputSection &sec) const {
+  for (auto [i, r] : llvm::enumerate(sec.relocations)) {
----------------
"Entrys" is not an English word


================
Comment at: lld/ELF/Arch/RISCV.cpp:1226
+    return;
+  isFinalized = true;
+
----------------
We call finalizeContents more than once?


================
Comment at: lld/ELF/SyntheticSections.cpp:42
 #include "llvm/Support/TimeProfiler.h"
-#include <cstdlib>
 
----------------
?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134600/new/

https://reviews.llvm.org/D134600