[PATCH] D148906: [AMDGPU] Remove incompatible attributes of function in amdgpu-remove-incompatible-functions pass

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh added a comment.

In D148906#4287237 <https://reviews.llvm.org/D148906#4287237>, @foad wrote:

> It looks like you just want a one-liner patch that adds FeatureWavefrontSize32 to the FeaturesToCheck table?

Indeed, if your goal is just to remove the functions that have +wavefrontsize32 on targets that doesn't support it, this is all you need to do.

I'm also not a fan of removing attributes in this pass. The pass is documented as "removes any function with incompatible attributes". If it also starts removing attributes then its description (& the CL option) would need to be updated to reflect the change (but really, I think this should be done somewhere else, perhaps in yet another pass).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148906/new/

https://reviews.llvm.org/D148906