[PATCH] D148782: [RISCV] Add an option to emit the Tag_RISCV_arch attribute based on the assembler's subtarget

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

LGTM, modulo my comment about testing stack align attribute behaviour.



================
Comment at: llvm/test/MC/RISCV/default-build-attributes.s:9
+# RUN:   -mattr=+m | FileCheck %s --check-prefixes=RV64M
+
+# RV32: attribute 5, "rv32i2p1"
----------------
As I understand it, your intent is that the stack alignment attribute isn't emitted with `-riscv-add-build-attributes` (which I assume matches GNU behaviuor) This file should probably test for that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148782/new/

https://reviews.llvm.org/D148782