[PATCH] D148782: [RISCV] Add an option to emit the Tag_RISCV_arch attribute based on the assembler's subtarget
Kito Cheng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 20 00:08:59 PDT 2023
kito-cheng accepted this revision.
kito-cheng added a comment.
This revision is now accepted and ready to land.
LGTM, this would be very useful for assembly files, since I believe most developer won't write attribute when writing assembly code, and `arch` attribute is also kind of hard to write it correctly by human - and it even need to sync with build system (`-march` option for assembler)! so I believe auto generate that is right way to go.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148782/new/
https://reviews.llvm.org/D148782
More information about the llvm-commits
mailing list