[PATCH] D148163: [compiler-rt] [test] [ubsan] Mark failing tests as unsupported for mingw configs
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 19 09:15:33 PDT 2023
mstorsjo updated this revision to Diff 514987.
mstorsjo added a comment.
Changed two cases into XFAIL with FIXME comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148163/new/
https://reviews.llvm.org/D148163
Files:
compiler-rt/test/ubsan/TestCases/Misc/monitor.cpp
compiler-rt/test/ubsan/TestCases/TypeCheck/Function/function.cpp
compiler-rt/test/ubsan/TestCases/TypeCheck/vptr-non-unique-typeinfo.cpp
compiler-rt/test/ubsan/TestCases/TypeCheck/vptr-virtual-base.cpp
compiler-rt/test/ubsan/TestCases/TypeCheck/vptr.cpp
Index: compiler-rt/test/ubsan/TestCases/TypeCheck/vptr.cpp
===================================================================
--- compiler-rt/test/ubsan/TestCases/TypeCheck/vptr.cpp
+++ compiler-rt/test/ubsan/TestCases/TypeCheck/vptr.cpp
@@ -44,6 +44,10 @@
// UNSUPPORTED: target={{.*openbsd.*}}
// Compilation error
// UNSUPPORTED: target={{.*freebsd.*}}
+// FIXME: For MinGW targets, the vptr tests do generally work, but Itanium
+// demangling isn't done for the type names. The "(echo ..." line fails to
+// be handled by the shell.
+// XFAIL: target={{.*windows-gnu.*}}
#include <new>
#include <typeinfo>
#include <assert.h>
Index: compiler-rt/test/ubsan/TestCases/TypeCheck/vptr-virtual-base.cpp
===================================================================
--- compiler-rt/test/ubsan/TestCases/TypeCheck/vptr-virtual-base.cpp
+++ compiler-rt/test/ubsan/TestCases/TypeCheck/vptr-virtual-base.cpp
@@ -6,6 +6,8 @@
// UNSUPPORTED: target={{.*windows-msvc.*}}
// Nested crash reported
// UNSUPPORTED: target={{.*freebsd.*}}
+// FIXME: Itanium demangling isn't done for the type names on MinGW targets.
+// XFAIL: target={{.*windows-gnu.*}}
struct S { virtual int f() { return 0; } };
struct T : virtual S {};
Index: compiler-rt/test/ubsan/TestCases/TypeCheck/vptr-non-unique-typeinfo.cpp
===================================================================
--- compiler-rt/test/ubsan/TestCases/TypeCheck/vptr-non-unique-typeinfo.cpp
+++ compiler-rt/test/ubsan/TestCases/TypeCheck/vptr-non-unique-typeinfo.cpp
@@ -3,7 +3,7 @@
// RUN: %run %t
//
// REQUIRES: cxxabi
-// UNSUPPORTED: target={{.*windows-msvc.*}}
+// UNSUPPORTED: target={{.*windows.*}}
struct X {
virtual ~X() {}
Index: compiler-rt/test/ubsan/TestCases/TypeCheck/Function/function.cpp
===================================================================
--- compiler-rt/test/ubsan/TestCases/TypeCheck/Function/function.cpp
+++ compiler-rt/test/ubsan/TestCases/TypeCheck/Function/function.cpp
@@ -4,7 +4,7 @@
// RUN: %run %t 2>&1 | FileCheck %s --check-prefix=CHECK $(%run %t-unique UNIQUE)
// Verify that we can disable symbolization if needed:
// RUN: %env_ubsan_opts=symbolize=0 %run %t 2>&1 | FileCheck %s --check-prefix=NOSYM $(%run %t-unique NOSYM-UNIQUE)
-// XFAIL: target={{.*windows-msvc.*}}
+// XFAIL: target={{.*windows.*}}
// Unsupported function flag
// UNSUPPORTED: target={{.*openbsd.*}}
Index: compiler-rt/test/ubsan/TestCases/Misc/monitor.cpp
===================================================================
--- compiler-rt/test/ubsan/TestCases/Misc/monitor.cpp
+++ compiler-rt/test/ubsan/TestCases/Misc/monitor.cpp
@@ -4,7 +4,7 @@
// __ubsan_on_report is not defined as weak. Redefining it here isn't supported
// on Windows.
//
-// UNSUPPORTED: target={{.*windows-msvc.*}}
+// UNSUPPORTED: target={{.*windows.*}}
// Linkage issue
// XFAIL: target={{.*openbsd.*}}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148163.514987.patch
Type: text/x-patch
Size: 2890 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230419/f1de43b1/attachment-0001.bin>
More information about the llvm-commits
mailing list