[PATCH] D148163: [compiler-rt] [test] [ubsan] Mark failing tests as unsupported for mingw configs

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: compiler-rt/test/ubsan/TestCases/TypeCheck/vptr-virtual-base.cpp:10
+// Itanium demangling isn't done for the type names.
+// UNSUPPORTED: target={{.*windows-gnu.*}}
 
----------------
alvinhochun wrote:
> Is this something that should be fixable? If so, maybe add a FIXME and use XFAIL instead?
It’s maybe fixable, yes (I’ve got a PoC, but I’m not sure if I’m violating some layering there etc, so I wanted to hold off of trying to sort that out for now.)

I guess an XFAIL and fixme comment might be in order here.


================
Comment at: compiler-rt/test/ubsan/TestCases/TypeCheck/vptr.cpp:50
+// the shell.
+// UNSUPPORTED: target={{.*windows-gnu.*}}
 #include <new>
----------------
alvinhochun wrote:
> Same as above,
This one is trickier than the one above; my PoC that hardwires itanium unwinding failed on other nontrivial shell constructs here, so it’s less clear than the other one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148163/new/

https://reviews.llvm.org/D148163