[PATCH] D148169: [compiler-rt] [test] [profile] Add an .exe suffix to some temp executables

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 19 09:00:38 PDT 2023


mstorsjo added inline comments.


================
Comment at: compiler-rt/test/profile/instrprof-basic.c:41
+// RUN: %run %t.dir4/merge4.exe
+// RUN: rm -f %t.dir4/merge4.exe
 // RUN: llvm-profdata merge -o %t.m4.profdata ./
----------------
alvinhochun wrote:
> Do you know is there any reason why this test case needs to remove the exe but the previous test cases don't? Can we instead just remove this rm command?
In this test, the profile data files are written in the same directory as the executable, and `llvm-profdata` reads all files the directory. If the executable is left there, it fails to read that file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148169/new/

https://reviews.llvm.org/D148169



More information about the llvm-commits mailing list