[PATCH] D143180: DAG: Expand legalization of is.fpclass to fcmp for DAZ

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 19 07:01:48 PDT 2023


arsenm added a comment.

ping



================
Comment at: llvm/include/llvm/ADT/FloatingPointMode.h:148
+  /// Return true if input denormals must be implicitly treated as 0.
+  constexpr bool inputsAreZero() const {
+    return Input == DenormalModeKind::PreserveSign ||
----------------
sepavloff wrote:
> The function name is not verb-based. Maybe `treatInputAsZero` or something like that?
Are is the verb? I think it reads fine 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143180/new/

https://reviews.llvm.org/D143180



More information about the llvm-commits mailing list