[PATCH] D148638: [DAG] Restrict (fp_round (copysign X, Y)) -> (copysign (fp_round X), Y) combine

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 10:02:45 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:16606
+/// Operands to the functions are the type of X and Y respectively.
+static inline bool CanCombineFCOPYSIGN_EXTEND_ROUND(EVT X, EVT Y) {
+  // Always fold no-op FP casts.
----------------
Can we use XVT and YVT or XTy and YTy? VT or Ty are almost always in the variable names for SelectionDAG types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148638/new/

https://reviews.llvm.org/D148638



More information about the llvm-commits mailing list