[PATCH] D148610: Clean come dead code

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 01:16:45 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/IfConversion.cpp:535
         if (DisableTriangleF && isFalse && !isRev) break;
-        if (DisableTriangleFR && isFalse && isRev) break;
         LLVM_DEBUG(dbgs() << "Ifcvt (Triangle");
----------------
skan wrote:
> Should we add an assertion `!(isFalse && isRev)` here?
Does this mean DisableTriangleFR is also dead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148610/new/

https://reviews.llvm.org/D148610



More information about the llvm-commits mailing list