[PATCH] D148610: Clean come dead code
Kan Shengchen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 18 01:12:58 PDT 2023
skan added inline comments.
================
Comment at: llvm/lib/CodeGen/IfConversion.cpp:535
if (DisableTriangleF && isFalse && !isRev) break;
- if (DisableTriangleFR && isFalse && isRev) break;
LLVM_DEBUG(dbgs() << "Ifcvt (Triangle");
----------------
Should we add an assertion `!(isFalse && isRev)` here?
================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:1620
std::pair<StringRef, StringRef> Split;
if (!MAI.useParensForSymbolVariant()) {
- if (FirstTokenKind == AsmToken::String) {
----------------
Assert `FirstTokenKind != AsmToken::String`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148610/new/
https://reviews.llvm.org/D148610
More information about the llvm-commits
mailing list