[PATCH] D146776: [llvm] Preliminary fat-lto-objects support

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 17 16:53:16 PDT 2023

aeubanks added a comment.

it'd be good to highlight somewhere that the thinlto-pre-link pipeline + module optimization pipeline is not exactly equivalent to the default pipeline (all the `Phase` params everywhere), so with this you'll get a different binary if you end up not going down the LTO route in the end than a typical non-fat build, especially if people ever want to adjust the thinlto pipeline (e.g. less aggressive inlining in the pre-link pipeline). the potential fiddling with the thinlto pre-link pipeline in the future is what has me most worried about this patch.

(the commit description is out of date referencing `PerModuleDefaultPipeline`)

I'd definitely like @tejohnson's feedback on this if there are any potential pitfalls we're missing

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list