[PATCH] D146776: [llvm] Preliminary fat-lto-objects support

[Paul Kirth via Phabricator via llvm-commits]

paulkirth updated this revision to Diff 514428.
paulkirth marked 9 inline comments as done.
paulkirth added a comment.

Address comments

- Fix typos and nits
- Clean up comments
- Remove use of EmitLLVMUseLists
- Use `embedBufferInModule` since it does exactly what we want: create a nameed metadata and section, and mark them exclude

TODO: deal w/ extension points


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146776/new/

https://reviews.llvm.org/D146776

Files:
  llvm/include/llvm/Bitcode/EmbedBitcodePass.h
  llvm/include/llvm/Passes/PassBuilder.h
  llvm/lib/Bitcode/Writer/CMakeLists.txt
  llvm/lib/Bitcode/Writer/EmbedBitcodePass.cpp
  llvm/lib/Object/ObjectFile.cpp
  llvm/lib/Passes/PassBuilder.cpp
  llvm/lib/Passes/PassBuilderPipelines.cpp
  llvm/lib/Passes/PassRegistry.def
  llvm/test/Bitcode/embed-multiple.ll
  llvm/test/Bitcode/embed-unsupported-object-format.ll
  llvm/test/Bitcode/embed.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146776.514428.patch
Type: text/x-patch
Size: 9349 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230417/4610ff31/attachment-0001.bin>