[PATCH] D148520: [VP] Add more functional SD opcodes to definitions. NFC

[Luke Lau via Phabricator via llvm-commits]

luke added a comment.

In D148520#4274501 <https://reviews.llvm.org/D148520#4274501>, @frasercrmck wrote:

> Is this really NFC though? Might the DAGCombiner not be able to match more patterns to `fma` with this information?
>
>   // fold (fadd (fmul x, y), z) -> (fma x, y, z)
>   if (isContractableFMUL(N0) && (Aggressive || N0->hasOneUse())) {
>     return matcher.getNode(PreferredFusedOpcode, SL, VT, N0.getOperand(0),
>                            N0.getOperand(1), N1);
>
> With knowledge about FMUL -> VP_FMUL, this code might now trigger? I'm not 100% familiar with this matcher code so it's just a hunch.
>
> It would be good to double-check this, add tests, and/or remove "NFC" from the description.

Good point, it’s definitely NFC-intended but will investigate this and add a test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148520/new/

https://reviews.llvm.org/D148520