[PATCH] D148520: [VP] Add more functional SD opcodes to definitions. NFC

Mon Apr 17 10:04:00 PDT 2023

frasercrmck added a comment.

Is this really NFC though? Might the DAGCombiner not be able to match more patterns to `fma` with this information?

  // fold (fadd (fmul x, y), z) -> (fma x, y, z)
  if (isContractableFMUL(N0) && (Aggressive || N0->hasOneUse())) {
    return matcher.getNode(PreferredFusedOpcode, SL, VT, N0.getOperand(0),
                           N0.getOperand(1), N1);

With knowledge about FMUL -> VP_FMUL, this code might now trigger? I'm not 100% familiar with this matcher code so it's just a hunch.

It would be good to double-check this, add tests, and/or remove "NFC" from the description.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148520/new/

https://reviews.llvm.org/D148520