[PATCH] D148331: [ARM] Fix t2BF_LabelPseudo.isTerminator

[Sam Elliott via Phabricator via llvm-commits]

lenary added a comment.

In D148331#4268092 <https://reviews.llvm.org/D148331#4268092>, @dmgreen wrote:

> I hadn't realized these were upstream. They probably needn't be without the rest of the pass. I believe internally these they are both terminators and non-terminators. In that they can be generated between two non terminators or between two terminators. That obviously doesnt make sense, and I think the whole thing probably needs to be rewritten. Thats not been very high priority though.

Yeah, understanding this Pseudo is really only possible with the downstream code, and we only got the EXPENSIVE_CHECKS failures downstream, but I realised this code is upstream which is why I put the fix upstream. If you have a better idea for the patch, feel free to commandeer it, or have someone like @simonwallis2 do so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148331/new/

https://reviews.llvm.org/D148331