[PATCH] D148116: [Analysis] Remove DA & LegacyDA
Pierre van Houtryve via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 14 03:36:52 PDT 2023
Pierre-vh added inline comments.
================
Comment at: llvm/lib/Analysis/SyncDependenceAnalysis.cpp:15
//
-// The SyncDependenceAnalysis is used in the DivergenceAnalysis to model
+// The SyncDependenceAnalysis is used in the UniformityAnalysis to model
// control-induced divergence in phi nodes.
----------------
sameerds wrote:
> foad wrote:
> > I don't think this is true. I think UA uses its own reimplementation of SDA, so this implementation could be removed.
> Yeah, nice catch!
It's a different analysis so if we remove it, I'd rather make a different patch if that's okay.
Do I just remove this sentence instead?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148116/new/
https://reviews.llvm.org/D148116
More information about the llvm-commits
mailing list