[PATCH] D148116: [Analysis] Remove DA & LegacyDA

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds added inline comments.


================
Comment at: llvm/docs/ConvergenceAndUniformity.rst:54
 semantics of convergent operations in LLVM IR. This is accompanied by
-a *uniformity analysis* that extends the existing divergence analysis
+a *uniformity analysis* that extends the (now removed) divergence analysis
 [DivergenceSPMD]_ to cover irreducible control-flow.
----------------
Pierre-vh wrote:
> foad wrote:
> > Maybe remove the whole sentence?
> There is a citation in there so I would like to find a way to keep it in or rephrase it
> @sameerds you wrote this document, how would you like me to update it?
You could say "extends previous work on divergence analysis".


================
Comment at: llvm/lib/Analysis/SyncDependenceAnalysis.cpp:15
 //
-// The SyncDependenceAnalysis is used in the DivergenceAnalysis to model
+// The SyncDependenceAnalysis is used in the UniformityAnalysis to model
 // control-induced divergence in phi nodes.
----------------
foad wrote:
> I don't think this is true. I think UA uses its own reimplementation of SDA, so this implementation could be removed.
Yeah, nice catch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148116/new/

https://reviews.llvm.org/D148116