[PATCH] D148159: [mlir][TransformDialect] Simplify the lowering of pack/unpack when these are just pad/unpad

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 13 02:35:32 PDT 2023


qcolombet updated this revision to Diff 513132.
qcolombet added a comment.

- Use all_of and llvm::seq where appropriate
- Use getMixedDimensions to future proof the code w.r.t. dynamic dimensions
- Early-exit to avoid else indentation


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148159/new/

https://reviews.llvm.org/D148159

Files:
  mlir/include/mlir/Dialect/Tensor/IR/TensorOps.td
  mlir/include/mlir/Dialect/Utils/IndexingUtils.h
  mlir/include/mlir/Dialect/Utils/ReshapeOpsUtils.h
  mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp
  mlir/lib/Dialect/Tensor/IR/TensorOps.cpp
  mlir/lib/Dialect/Utils/IndexingUtils.cpp
  mlir/lib/Dialect/Utils/ReshapeOpsUtils.cpp
  mlir/test/Dialect/Linalg/transform-lower-pack.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148159.513132.patch
Type: text/x-patch
Size: 23855 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230413/0485a774/attachment.bin>


More information about the llvm-commits mailing list