[PATCH] D148159: [mlir][TransformDialect] Simplify the lowering of pack/unpack when these are just pad/unpad

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Utils/IndexingUtils.h:208
+computePermutationVector(int64_t permSize, ArrayRef<int64_t> positions,
+                         ArrayRef<int64_t> desiredPositions);
+
----------------
qcolombet wrote:
> I ended up not needing this refactoring but I wanted to show it nevertheless.
> 
> I'll remove them from that commit after I get your feedbacks.
> Do you think it makes sense to expose these in the utility functions (in that case I'll make a separate NFC commit) or should I just drop them all together?
I think these are useful utils to expose in general, fine as is IMO.


================
Comment at: mlir/include/mlir/Dialect/Utils/ReshapeOpsUtils.h:535
+PackingMetadata computePackingMetadata(int64_t packedRank,
+                                       ArrayRef<int64_t> innerDimPos);
 } // namespace mlir
----------------
qcolombet wrote:
> Ditto, not needed but I wanted to show it to you.
I think these are useful utils to expose in general, fine as is IMO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148159/new/

https://reviews.llvm.org/D148159